Friday, October 31, 2008

Position of label on checkbox inputs

Hi,

Is there a reason $out is appended to the end in form->input when
$type is set to checkbox? This behaviour is different to all the other
types which place label before the input and is causing me issues with
my layout. I can fix this by moving the out variable between $before
and the checkbox but i don't want to do this if $out is at the end by
design and this will break something. I have had no issues so far but
this may break somethign i have not come across yet.

I am using version 1.2.0.7296 RC2

Thanks,

Tom


tom@bender:~/jobzone$ git diff cake/libs/view/helpers/form.php
diff --git a/cake/libs/view/helpers/form.php b/cake/libs/view/helpers/
form.php
index 33639b2..35d06c6 100644
--- a/cake/libs/view/helpers/form.php
+++ b/cake/libs/view/helpers/form.php
@@ -735,7 +735,7 @@ class FormHelper extends AppHelper {
unset($divOptions);
break;
case 'checkbox':
- $out = $before . $this-
>checkbox($fieldName, $options) . $between . $out;
+ $out = $before . $out . $this-
>checkbox($fieldName, $options) . $between;
break;
case 'radio':
$out = $before . $out . $this-
>radio($fieldName, $radioOptions, $options) . $between;

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups "CakePHP" group.
To post to this group, send email to cake-php@googlegroups.com
To unsubscribe from this group, send email to cake-php+unsubscribe@googlegroups.com
For more options, visit this group at http://groups.google.com/group/cake-php?hl=en
-~----------~----~----~----~------~----~------~--~---

No comments: